fix(ui-alerts): trigger onDismiss for SR-only alerts #1718
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
csmaty
changed the title
csmaty
changed the title
|
Thanks for the contribution, we will check it out soon |
|
it works great, thanks for the fix! Can you please squash the commits into one so there is just one with the |
joyenjoyer
requested changes
Oct 18, 2024
csmaty
force-pushed
the
fix/sr-only-alert-ondismiss
branch
from
5fdd33e
to
c4f3328
Compare
|
@matyasf @joyenjoyer Squashed into a single commit. |
matyasf
approved these changes
Oct 21, 2024
joyenjoyer
approved these changes
Oct 30, 2024
|
Thanks for the contribution, we will release this soon! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
onDismisswas not being fired onscreenReaderOnlyalerts, unlesstransition: 'none'was specified alongside.Default transition value is
'fade'. This change makesscreenReaderOnlyalerts an implicittransition: 'none'when executingonDismiss.Credits for finding this bug: @meister245